CloudWatch: Fix query editor does not render in Explore #20909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
approved these changes
Dec 5, 2019
|
@davkal added this to 6.5.2 milestone |
torkelo
approved these changes
Dec 5, 2019
| import { Input, Segment, SegmentAsync, ValidationEvents, EventsWithValidation, Switch } from '@grafana/ui'; | ||
| import { CloudWatchQuery } from '../types'; | ||
| import CloudWatchDatasource from '../datasource'; | ||
| import { SelectableStrings } from '../types'; | ||
| import { Stats, Dimensions, QueryInlineField, QueryField, Alias } from './'; | ||
|
|
||
| export type Props = QueryEditorProps<CloudWatchDatasource, CloudWatchQuery>; | ||
| export type Props = ExploreQueryFieldProps<CloudWatchDatasource, CloudWatchQuery>; |
There was a problem hiding this comment.
Ok for a quick fix, but really wish we could unify these interfaces, I see very recently that ExploreQueryFieldProps has now a NEW prop in master (compared to 6.5) (absoluteRange?: ) the plan was to get rid of the differences not expand them. Can't find the PR where this was added, do you know?
history could be handled easily internally by each editor, and onBlur could be added to main interface. not sure what this absoluteRange is used for. PanelData has a timeRange property already.
There was a problem hiding this comment.
or query history could potentially be made into a more universal feature that we can shared between dashboard / explore.
marefr
changed the title
marefr
changed the title
marefr
changed the title
mckn
pushed a commit
that referenced
this pull request
Dec 11, 2019
* Defined explore query editor for cloudwatch * Fix types (cherry picked from commit ab3df98)
mckn
pushed a commit
that referenced
this pull request
Dec 11, 2019
* Defined explore query editor for cloudwatch * Fix types (cherry picked from commit ab3df98)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20805