Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment about upcoming alerting for singlestat and table panels #21416

Merged
merged 1 commit into from Jan 9, 2020

Conversation

theneva
Copy link
Contributor

@theneva theneva commented Jan 9, 2020

This might help with the general tone of voice in #6983

This might help with the general tone of voice in grafana#6983 😕
@claassistantio
Copy link

claassistantio commented Jan 9, 2020

CLA assistant check
All committers have signed the CLA.

@stefanotorresi
Copy link

May I suggest rewording to:

Currently, only the *Graph* panel supports alert rules; support for other types of panels like *Singlestat* and *Table* may come in the future.

Also linking the open issue may be a good idea, but I'm new here so I don't know if it's common to have GH references in the docs.

@torkelo
Copy link
Member

torkelo commented Jan 9, 2020

The current plan is to make alert rules it's own standalone thing (so not created as part of any panel or dashboard)

@torkelo torkelo merged commit 418cb9a into grafana:master Jan 9, 2020
@theneva theneva deleted the patch-1 branch January 9, 2020 13:18
@zimza
Copy link

zimza commented Jan 10, 2020

The current plan is to make alert rules it's own standalone thing (so not created as part of any panel or dashboard)

Great news !

@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants