Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Monitor: Fix Application Insights API key field to allow input #21738

Merged
merged 2 commits into from Jan 29, 2020
Merged

Azure Monitor: Fix Application Insights API key field to allow input #21738

merged 2 commits into from Jan 29, 2020

Conversation

shavonn
Copy link
Contributor

@shavonn shavonn commented Jan 24, 2020

Fixes #21737

@shavonn shavonn self-assigned this Jan 24, 2020
@marefr
Copy link
Member

marefr commented Jan 27, 2020

This feels like a quite important bug fix. Should probably be targeted for next 6.6 patch release?

@marefr marefr changed the title Fix update api key input Azure Monitor: Fix Application Insights API key field not allowing input Jan 27, 2020
@marefr marefr changed the title Azure Monitor: Fix Application Insights API key field not allowing input Azure Monitor: Fix Application Insights API key field to allow input Jan 27, 2020
sunker
sunker reviewed Jan 27, 2020
View reviewed changes
Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have knowledge/background to test this and cannot really understand the impact of this change. Would be great to get a demo and some explanations after today's standup.

@shavonn shavonn requested a review from sunker January 27, 2020 15:26
@shavonn
Copy link
Contributor Author

shavonn commented Jan 27, 2020

This feels like a quite important bug fix. Should probably be targeted for next 6.6 patch release?

@marefr Yes, it is and should be!

@marefr marefr added this to the 6.6.1 milestone Jan 27, 2020
@marefr
Copy link
Member

marefr commented Jan 27, 2020

Thanks. Added it to 6.6.1

@srclosson
Copy link
Member

Testing this has been a nightmare. There is something else going on in the latest version of grafana, and since this branched off of master, it would seem something pushed in the last couple of days causes saving the datasource to logout the grafana user.

Looking at these changes though, I cannot see why this would have any affect. Approving.

@shavonn shavonn merged commit 0fa20cb into master Jan 29, 2020
@shavonn shavonn deleted the 21737-insights-api-key-update branch January 29, 2020 04:47
aknuds1 pushed a commit that referenced this pull request Jan 29, 2020
@aknuds1
Azure Monitor: Fix Application Insights API key field to allow input (#…
756f77d 
…21738)

* Fix update api key input

* update snapshot
alexanderzobnin pushed a commit that referenced this pull request Feb 5, 2020
@alexanderzobnin
Azure Monitor: Fix Application Insights API key field to allow input (#…
8de5211 
…21738)

* Fix update api key input

* update snapshot

(cherry picked from commit 0fa20cb)
alexanderzobnin pushed a commit that referenced this pull request Feb 6, 2020
@alexanderzobnin
Azure Monitor: Fix Application Insights API key field to allow input (#…
94c374d 
…21738)

* Fix update api key input

* update snapshot

(cherry picked from commit 0fa20cb)
@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srclosson srclosson srclosson approved these changes

@sunker sunker Awaiting requested review from sunker

Assignees

@shavonn shavonn

Labels
add to changelog area/datasource/frontend datasource/Azure Azure Monitor Datasource pr/external This PR is from external contributor type/bug
Projects
None yet
Milestone
6.6.1
Development

Successfully merging this pull request may close these issues.

Azure Monitor: Application Insights API Key Field Not Allowing Input
6 participants
@shavonn @marefr @srclosson @sunker @alexanderzobnin @ying-jeanne