-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templating: Migrates some variable types from Angular to React/Redux #22434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok 99/99 files viewed!
Amazing work ❤️
Was not much that I could find that looked off or I could not understand the reasons for.
Will do more testing but since it's behind a feature toggle I think we can do that after merge as well.
Thanks for all the great feedback @torkelo and @dprokop and it feels great to have come this far finally! |
… into hugoh/newVariables
…hugoh/newVariables
… into hugoh/newVariables
…hugoh/newVariables
What this PR does / why we need it:
Fourth iteration trying to move template variables to Redux. This iteration takes the React/Redux parts from the third iteration #21873 and does (almost) no integration with Angular components. Everything is behind the feature toggle called
newVariables
and will be a completely new property in thedashboard.json
=>variables.list
.Misc
Known issues so far:
When we have nothing else to do:
uuid
as parameter instead ofvariable
to avoid stupid bugsWrite a class that walks the variable tree and create an execution order.Upcoming PRs
Which issue(s) this PR fixes:
Closes #19896
Special notes for your reviewer:
Not covered in this PR