Table: upgrades react-table to 7.0.0 and typings #23247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
reviewed
Apr 1, 2020
| @@ -57,6 +61,7 @@ export function getColumns(data: DataFrame, availableWidth: number, columnMinWid | |||
|
|
|||
| columns.push({ | |||
| Cell, | |||
| id: field.name, | |||
There was a problem hiding this comment.
field name is not guaranteed to be unique sadly (A table can include multiple fields with same name). Can we use index instead?
There was a problem hiding this comment.
Great catch, I'll do that instead!
There was a problem hiding this comment.
So I tried several approaches, but no one worked.
- Adding index as id, react-table will replace the id with the Header name
- Using the accessor to retrieve the field failed too because it didn't match the correct memory area, got [object, object] instead of real values.
- Using the accessor to retrieve the index of field failed too for unknown reason, got strange values instead of real values.
So I settled with just using index from the loops, which seem to work for now when we don't have reordering of columns. I really don't like the react-table API because I'm just not getting it at all.
torkelo
approved these changes
Apr 1, 2020
dprokop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Relates #20709
Special notes for your reviewer: