Docker: Upgrade to Alpine 3.11 #24056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
commented
Apr 29, 2020
aknuds1
requested review from
xlson,
sakjur,
a team and
marefr
and removed request for
a team
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
added a commit
that referenced
this pull request
Apr 30, 2020
* Docker: Upgrade to Alpine 3.11
|
Please add support to use curl for health checks in docker images .. we don't have this feature in base docker image. We need to go to grafana Ubuntu base image. |
|
@restlessankyyy care to make a feature request? That's a better way of bringing this issue to our attention. |
|
@aknuds1 is the milestone wrong on this PR , maybe it was never cherry picked? |
|
@torkelo the commit is in 7.0.3 tag. |
|
Ok, great . Eldin was unsure if this made it into the release |
|
Thanks I will check and see if it works. |
aknuds1
added a commit
that referenced
this pull request
Jun 30, 2020
* Docker: Upgrade to Alpine 3.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upgrade our Docker images to base themselves on Alpine 3.11.
Which issue(s) this PR fixes:
Fixes #21920.
Special notes for your reviewer:
I also make sure to upgrade our base images to latest Go and Node v12.
I've scanned the image built from /Dockerfile, finding no vulnerabilities: