PanelEditor: Fixes issue changing panel type from graph to stat and thresholds not taking affect after going back to dashboard #24144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
pushed a commit
that referenced
this pull request
Jun 30, 2020
…hresholds not taking affect after going back to dashboard (#24144) * PanelEditor: Fixes issue with panel type change and query result reuse * removed unused imports * removed unused imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PanelModel.plugin was not updated when switching panel plugin in new edit mode, leading to field config registry not updating to new plugin type etc.
Also fixes issues of not reusing query result when switching from angular to react and going back to dashboard.