Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing: Update Typescript version in jaeger-ui-component #24156

Merged
merged 1 commit into from May 1, 2020

Conversation

aocenas
Copy link
Member

@aocenas aocenas commented May 1, 2020

We used different version from the main code base so some syntax did not work the same way.

@aocenas aocenas added this to the 7.0 milestone May 1, 2020
@aocenas aocenas requested review from a team and davkal and removed request for a team May 1, 2020 12:49
Copy link

@Estrax Estrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aocenas aocenas mentioned this pull request May 1, 2020
@aocenas aocenas added this to Under review in Observability (deprecated, use Observability Squad) via automation May 1, 2020
@aocenas aocenas merged commit 442c087 into master May 1, 2020
Observability (deprecated, use Observability Squad) automation moved this from Under review to Done May 1, 2020
@aocenas aocenas deleted the aocenas/tracing/update-typescript branch May 1, 2020 13:26
aknuds1 pushed a commit that referenced this pull request May 7, 2020
aknuds1 pushed a commit that referenced this pull request May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants