Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger: Fix how label is created in cascader #24164

Merged
merged 1 commit into from
May 5, 2020

Conversation

aocenas
Copy link
Member

@aocenas aocenas commented May 1, 2020

Fixes: #24157

Searches for root span when creating label for 3rd level of cascader.

@aocenas aocenas requested review from a team and Estrax and removed request for a team May 1, 2020 15:54
@aocenas aocenas added this to Under review in Observability (deprecated, use Observability Squad) via automation May 1, 2020
@aocenas aocenas added this to the 7.0 milestone May 1, 2020
Copy link

@Estrax Estrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aocenas aocenas merged commit 9b1c045 into master May 5, 2020
Observability (deprecated, use Observability Squad) automation moved this from Under review to Done May 5, 2020
@aocenas aocenas deleted the aocenas/tracing/fix-jaeger-cascader branch May 5, 2020 12:21
pull bot pushed a commit to digitalocean/grafana that referenced this pull request May 5, 2020
aknuds1 pushed a commit that referenced this pull request May 7, 2020
aknuds1 pushed a commit that referenced this pull request May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Jaeger: Trace selector does not show root span
3 participants