New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variables: Fixes maximum call stack bug for empty value #25503
Conversation
good catch, will look into this! |
If I understand your comment right @aocenas this is the intended behavior for all variables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Error is no longer there!
@hugohaggmark
This still seems like a bug to me. |
But I am ok if that is solved separately. |
Would be great if you could file that as a separate issue @aocenas 🙏 |
What this PR does / why we need it:
When using an empty value for a Text variable the logic that checked for variable changes in URL got into an endless loop. This PR tries to remedy this.
Which issue(s) this PR fixes:
Fixes #25485
Special notes for your reviewer: