Dashboard: Redirects for old (pre 7.0) edit & view panel urls #25653
Conversation
| @@ -55,4 +55,21 @@ func TestMiddlewareDashboardRedirect(t *testing.T) { | |||
| }) | |||
| }) | |||
| }) | |||
|
|
|||
| Convey("Given the dashboard legacy edit panel middleware", t, func() { | |||
There was a problem hiding this comment.
We might want to rewrite this using the standard testing library, since we're committed to getting rid of Convey.
There was a problem hiding this comment.
Then we have to convert this whole file, what test runners are you using?
There was a problem hiding this comment.
@torkelo We just use go test for running tests. In this case, I think it would be easy to write this test without Convey. That's what I usually do when adding new tests, just write them with the standard library, in addition to the existing Convey ones (which I guess we'll clean up at some point).
There was a problem hiding this comment.
go test is terrible, have scroll a bunch to see what failed due to stack traces that are more than a screen long, and it does not rerun tests on file change (no watch), so the whole experience I find very poor. Like having a test runner in a tmux split that runs tests on file change and print failures in readable form.
I tried to rewrite this to go testing library but sadly it depends on middlewareScenario which uses GoConvey so have to rewrite hundreds of tests to go testing library to convert this test :(
|
no the old urls always had panelId & fullscreen, and then edit no edit depending on view/edit mode. which is why I simplified the state a big for 7.0 to just have editPanel and viewPanel to cover both states with just two states instead of 3 properties |
(cherry picked from commit d6ed8c5)
(cherry picked from commit d6ed8c5)
Closes #25459