Datasources: add new tab and feature toggle #25663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgnesToulet
requested review from
torkelo and
tskarhed
and removed request for
a team
|
Yes, I just created the other PR in the Enterprise repo. |
|
Maybe it makes sense to show this only in Enterprise version to prevent confused 404 if feature toggled in open source? |
|
You shouldn't be able to see the Insights tab without an Enterprise license even if the feature is enabled. |
alexanderzobnin
approved these changes
Jun 17, 2020
aknuds1
pushed a commit
that referenced
this pull request
Jun 30, 2020
* Datasources: add insights tab * Config: add feature flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a new tab and a feature toggle to enable a new Enterprise feature (Datasource Insights)