@grafana/e2e: improvements #25677
@grafana/e2e: improvements #25677
Conversation
… where it appeared as though the wrong one was selected
... thrown from RxJS
stevenvachon
added
type/e2e
stevenvachon
requested review from
hugohaggmark,
jhunthrop,
scottlepp,
srclosson,
briangann and
a team
| e2e().wait('@chartData'); | ||
|
|
||
| // Wait for RxJS | ||
| e2e().wait(500); |
There was a problem hiding this comment.
I agree that it's not a great solution, but It doesn't kill it after 500ms, it simply waits for one of our RxJS actions. I don't know why, but Cypress screenshot() causes RxJS to fail without the delay.
I'm not sure what logging a would message accomplish as it'd be something like log('Hopefully avoided "executing a canceled action" error from RxJS').
There was a problem hiding this comment.
what happens if rxjs is not loaded?
There was a problem hiding this comment.
is there a way to determine what you are waiting for has loaded?
There was a problem hiding this comment.
Not that I know of. RxJS isn't a global.
There was a problem hiding this comment.
i'm ignorant here with cypress. can you execute something that would test the existence of rxjs?
There was a problem hiding this comment.
This sounds very disturbing, I'd like to look into this closer but will not have time today. RxJs is our library for streaming data from the backendSrv to visualisations so we really don't know when it's completed.
There was a problem hiding this comment.
"Streaming" doesn't sound like a normal request, so perhaps it can be covered in the near future with cypress-io/cypress#687
There was a problem hiding this comment.
i'm ignorant here with cypress. can you execute something that would test the existence of rxjs?
Not that I can think of. We can wait() for requested URLs (currently only XMLHttpRequest and not fetch()).
* Minor changes * Fixed data source selection issue … where it appeared as though the wrong one was selected * Fixed “executing a canceled action” issue ... thrown from RxJS
ying-jeanne
added
pr/external
See commit message(s).