Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units: Match 'length' case with other categories #25702

Merged
merged 1 commit into from Jun 22, 2020
Merged

Units: Match 'length' case with other categories #25702

merged 1 commit into from Jun 22, 2020

Conversation

der-eismann
Copy link
Contributor

What this PR does / why we need it: This PR is changing the length category to Length, because it was the only unit category starting with a lowercase letter.

Just a tiny PR, but this really bugged me.

@der-eismann der-eismann requested review from a team, peterholmberg and tskarhed and removed request for a team June 18, 2020 16:28
@CLAassistant
Copy link

CLAassistant commented Jun 18, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@peterholmberg peterholmberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't noticed until now but 🤯

@peterholmberg peterholmberg merged commit b8d4999 into grafana:master Jun 22, 2020
pull bot pushed a commit to digitalocean/grafana that referenced this pull request Jun 22, 2020
@der-eismann der-eismann deleted the make-category-start-with-uppercase branch June 22, 2020 06:59
@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants