Admin: Update org list after delete #26277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarity-89
requested review from
peterholmberg
and removed request for
a team and
peterholmberg
|
Seems OK, but long term I think we should consider altering the local state first and then re-fetching the list. Sort of optimistic update. With the proposed solution I can see weird behaviour i.e. when the connection is slow:
|
Yeah, makes sense. But then we'll need to be able to revert the state if the api call has errors. Do we have any functionality like this available? |
nothing reusable unfortunately |
dprokop
approved these changes
Jul 15, 2020
dprokop
pushed a commit
that referenced
this pull request
Jul 16, 2020
(cherry picked from commit 208f95a)
dprokop
pushed a commit
that referenced
this pull request
Jul 16, 2020
(cherry picked from commit 208f95a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently the list of organisations is not updated after an organisation has been deleted, unless the page is refreshed. This PR makes sure that
fetchOrgsapi call happens after thedeleteOrgcall completed.