Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus: Correctly format multi values variables in queries #26896

Merged
merged 1 commit into from Aug 10, 2020

Conversation

ivanahuckova
Copy link
Member

What this PR does / why we need it:
More on this here and here.

Before:
image

After:
image

Which issue(s) this PR fixes:

Fixes #23434

@ivanahuckova ivanahuckova requested a review from a team as a code owner August 10, 2020 12:36
@ivanahuckova ivanahuckova requested review from aocenas, torkelo and zoltanbedi and removed request for a team and aocenas August 10, 2020 12:36
@ivanahuckova ivanahuckova self-assigned this Aug 10, 2020
@ivanahuckova ivanahuckova added this to the 7.2 milestone Aug 10, 2020
Copy link
Member

@torkelo torkelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ivanahuckova ivanahuckova merged commit ad33734 into master Aug 10, 2020
Observability (deprecated, use Observability Squad) automation moved this from Under review to Done Aug 10, 2020
@ivanahuckova ivanahuckova deleted the ivana/prom-multiple-vars branch August 10, 2020 13:36
@ivanahuckova ivanahuckova modified the milestones: 7.2, 7.1.4 Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Prometheus datasource doesn't format multi values correctly in queries
2 participants