Chore: Upgrade to Go 1.15.1

[aknuds1]

What this PR does / why we need it:
Upgrade to Go 1.15.1.

[marefr]

Changes seems reasonable. This feels like a potentially risky update going from 1.14.7 to 1.15.1 given there's 7.2 beta release in one week. Have you verified all changes in 1.15 looks solid and non-breaking?

Is this maybe to resolve recent security vulnerability?

[sakjur]

@marefr 1.15 isn't a very exciting release, and I've been running Grafana on master with 1.15 without any problems since the day of the 1.15 release without noticing any negative consequences.

It is possible that we might have users (for example orgs rolling internal certificates) that could run into the deprecation of x.509 certificate's common name happening in 1.15: https://golang.org/doc/go1.15#commonname

I think, in a sense, that it makes sense to use the beta to verify that the behavior of 1.15 is not significantly changed in any way from the behavior of 1.14, where upgrading from 1.14->1.15 in a later patch release (or worse, 1.14->1.16 when that drops, since 1.14 won't be getting security patches at that point) wouldn't let us have the confidence of a tested beta behind us. Having a beta release ahead of us is better than a patch release.

[aknuds1]

@marefr Yeah, the idea was to bring us up to date with latest Go, and to get the security fix in 1.15.1. I read the release notes and didn't find anything that would break.

[aknuds1]

I agree with @sakjur that it would make sense to test Go 1.15 as part of the beta.

[kylebrandt]

Should go.mod go version be updated with this as well?

[marefr]

It is possible that we might have users (for example orgs rolling internal certificates) that could run into the deprecation of x.509 certificate's common name happening in 1.15: https://golang.org/doc/go1.15#commonname

You can use a env variable to set this back so should be fine.

I approve

[sakjur]

It is possible that we might have users (for example orgs rolling internal certificates) that could run into the deprecation of x.509 certificate's common name happening in 1.15: https://golang.org/doc/go1.15#commonname

You can use a env variable to set this back so should be fine.

Yes! We just need to be aware of it in case it appears in a bug report or something like that :)