Timezones: Include IANA timezone canonical name in TimeZoneInfo #27591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mckn
reviewed
Sep 15, 2020
| if (!momentTz) { | ||
| return undefined; | ||
| } | ||
|
|
||
| return { | ||
| name: timeZone, | ||
| ianaName: momentTz.name, |
There was a problem hiding this comment.
I think the proper name is olsonId.
There was a problem hiding this comment.
Did a quick check on this and seems like there is no clear winner;) I think I'll stay with iana as Wikipedia states Olson database is occasionally used in as a name of this DB
mckn
approved these changes
Sep 15, 2020
| @@ -1,3 +1,5 @@ | |||
| process.env.TZ = 'UTC'; | |||
There was a problem hiding this comment.
I guess this is deliberate, but feels very strange.
There was a problem hiding this comment.
Yeah, had the same feeling but apparently this is the way jest wants the time zone to be set. I have not found any other way to get the timezone "mocked".
hugohaggmark
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://www.iana.org/time-zones , https://en.wikipedia.org/wiki/List_of_tz_database_time_zones
This PR also sets the global timezone for tests to UTC.