Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML Single Logout #27995

Merged
merged 10 commits into from Oct 8, 2020
Merged

SAML Single Logout #27995

merged 10 commits into from Oct 8, 2020

Conversation

alexanderzobnin
Copy link
Contributor

What this PR does / why we need it:
This is an open source part of SAML Single Logout PR.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@alexanderzobnin alexanderzobnin requested a review from a team as a code owner October 2, 2020 08:03
@alexanderzobnin alexanderzobnin requested review from wbrowne, marefr and sakjur and removed request for a team October 2, 2020 08:03
@marefr
Copy link
Member

marefr commented Oct 2, 2020

@alexanderzobnin need to do a go mod tidy to fix failed build

Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but added a suggestion

docs/sources/enterprise/saml.md Outdated Show resolved Hide resolved
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but don't have the details of the feature)

@alexanderzobnin alexanderzobnin added this to the 7.3 milestone Oct 8, 2020
@alexanderzobnin alexanderzobnin merged commit b55a51e into master Oct 8, 2020
@alexanderzobnin alexanderzobnin deleted the saml-slo branch October 8, 2020 14:42
ryantxu pushed a commit that referenced this pull request Nov 18, 2020
* SAML: single logout WIP

* SAML: sign SAML requests

* SAML: remove unnecessary logs

* fix go mod file

* Docs: Single Logout

* SAML: use api endpoint for single logout

* Apply suggestions from code review

Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>

* SAML: save context for single logout

* Chore: add SAML dependencies

Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants