Graph NG: exemplars support WIP #28071
Conversation
dprokop
requested review from
torkelo,
mckn,
hugohaggmark,
ryantxu,
zoltanbedi and
a team
| // An abstraction over a component rendered within a chart canvas. | ||
| // Marker is rendered with DOM coords of the chart bounding box. |
There was a problem hiding this comment.
| // An abstraction over a component rendered within a chart canvas. | |
| // Marker is rendered with DOM coords of the chart bounding box. | |
| /** | |
| * An abstraction over a component rendered within a chart canvas. | |
| * Marker is rendered with DOM coords of the chart bounding box. | |
| */ |
| canvasRef: any; | ||
| data: DataFrame; | ||
| } | ||
|
|
||
| export const PlotContext = React.createContext<PlotContextType | null>(null); | ||
| export const PlotContext = React.createContext<PlotContextType>({} as PlotContextType); |
There was a problem hiding this comment.
nit: I think using null is clearer here, but no biggie
| ` | ||
| )} | ||
| > | ||
| <div ref={markerRef} onMouseEnter={onMouseEnter} onMouseLeave={onMouseLeave} className={cx(styles.markerWrapper)}> |
There was a problem hiding this comment.
nit: don't think you need cx in this case
There was a problem hiding this comment.
Awesome job!
Think there are some follow-up issues we need to look at.
- Not sure if we should continue using AnnotationEvent, think @ryantxu have plans to deprecate that and use DataFrame directly instead. For example, AnnotationEvent does not have data links that we need for the exemplars. but the field has data links.
- Observable & useEffects only for simple data model transforms feels inefficient (both for this here and in the main GraphPanel for getting aligned data). Need sync util functions for merge & join transforms.
Yup, aware of that. Using the AnnotationEvent here is just to keep the ball rolling :) |
|
@torkelo @ryantxu removed the usage of the AnnotationEvent in favor of DataFrame (and DataFrameView for fields inspection) in Annotations & Exemplars plugins. FYI @zoltanbedi |
* Use annotations data observable * WIP exemplars * Refactor usePlotContext to use getters instead of properties * Use DataFrame in EventsCanvas instead of custom type * Minor tweaks
This PR brings some refactorings in order to support exemplars in the same way as annotations.
Main highlights of the changes proposed:
T extends AnnotationEventthat we will probably need to adjust to something shared between annotations and exemplars. Uses simple primitiveXYCavasunder the hood for the Markers to be rendered in correct positionsplotCtx.u && plotCtx.u.series && plotCtx.canvas) the context now exposesisPlotReadyproperty tat indicates it's safe to use all the getters.TODO:
valueToPosAPI. For this to work we need to identify which scale are the exemplars using. @zoltanbedi currently the scales in the graph are created using Field's unit configuration. If there is no unit configured then the default scale is called '_fixed'. I assume for the exemplars we won't have a unit? What's the thinking about this?