annotations: fetch all grafana annotations when no tags or dashboard ID is specified #29033
Conversation
kevingessner
requested review from
a team,
hugohaggmark and
peterholmberg
and removed request for
a team
|
|
…ID is specified This makes the Tags type more useful without removing existing behavior or adding another option.
kevingessner
force-pushed
the
all-annotations
branch
from
65925ac
to
dee84d8
Compare
There was a problem hiding this comment.
@kevingessner I'm sorry, but we rarely take contributions without a feature request that has a reasonable amount of feedback/upvotes. We'll probably have a look next week.
All the best
hugohaggmark
added
pr/external
|
@hugohaggmark Would it be helpful if I created a feature request issue to go along with this? |
Yes, that would be a great start, still that doesn't mean we'll accept this PR. It depends on popular demand like feedback/upvotes, complexity e.t.c. Thank you |
|
I've submitted #29105 for this! Thanks for taking a look. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
bump -- issue is in the backlog of feature requests |
|
This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
(bump) |
|
We've looked at this and having it to default to fetch all annotations is not a great experience for users that have a lot of annotations. There should be an explicit choice in the UI somehow, so users know that making this choice will cause fetching all annotations. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
Closing this as I think fetching all annotations without any filter feels like a bad idea |
What this PR does / why we need it:
There's currently no way to have a dashboard/panel display all Grafana-stored annotations -- you can either show them just on the panel where they were created, or by tag. This changes the behavior of the Tags type with no tags specified: it now fetches all annotations, instead of none. This enables showing all annotations, instead of an otherwise unuseful behavior.
Special notes for your reviewer:
I ran the go and jest tests and they pass.