Stat/Gauge: expose explicit font sizing #29476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
changed the title
2 tasks
torkelo
reviewed
Dec 1, 2020
torkelo
reviewed
Dec 1, 2020
|
Bar gauge still needs some work: |
torkelo
reviewed
Dec 4, 2020
There was a problem hiding this comment.
Think we have a bug (not related to this PR) but when two panels share the same panel options, the values stay in the UI but are not taking effect, I need to update the value again for it to take effect.
For example have stat panel, set value size 100, switch to Gauge, the options in the side bar stay at 100 in the input but the viz is not afffected, but if update to 99 or something else it will take effect
ryantxu
requested review from
a team,
hugohaggmark and
kaydelaney
and removed request for
a team
ryantxu
added a commit
that referenced
this pull request
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This exposes a explicit font size settings for 'title' and 'value' in the stats and gauge panels
Rather than trying to be tricky with settings (like #28091), this just exposes them directly:
Which issue(s) this PR fixes:
Fixes #23305, helps #22209
Special notes for your reviewer:
alternative to #28091