Variables: Fixes Textbox current value persistence #29481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugohaggmark
changed the base branch from
master
to
hugoh/fix-variable-confusion
hugohaggmark
requested review from
oddlittlebird,
osg-grafana and
aocenas
and removed request for
a team
hugohaggmark
changed the base branch from
hugoh/fix-variable-confusion
to
master
hugohaggmark
changed the base branch from
master
to
hugoh/fix-variable-confusion
dprokop
approved these changes
Dec 1, 2020
public/app/features/variables/textbox/TextBoxVariablePicker.tsx
Outdated
Show resolved
Hide resolved
ryantxu
pushed a commit
that referenced
this pull request
Dec 8, 2020
* Variables: Fixes savequery for Constant and TextBox variables * Refactor: reverts textbox changes * Refactor: Fixes dashboard export and tests * Refactor: hides or migrates Constant variables * Tests: fixes snapshots * Variables: Fixes Textbox current value persistance * Refactor: fixes PR comments and adds e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is a branch off from #29407 and tries to make persistence for text box variables clearer.
Which issue(s) this PR fixes:
Fixes #28991
Special notes for your reviewer: