SingleStat: Fix issue with panel links #32721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjulianm
requested review from
a team,
torkelo and
dprokop
and removed request for
a team
|
|
torkelo
changed the title
grafanabot
pushed a commit
that referenced
this pull request
Apr 7, 2021
(cherry picked from commit fbabed2)
torkelo
pushed a commit
that referenced
this pull request
Apr 7, 2021
ifrost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: I noticed a regression in Grafana 7.4.0, where SingleStat links stopped working. It was a bug introduced in 683ce69, where the signature of getDataLinkUIModel changed but was not updated properly in the SingleStat panel. I updated it following similar changes made in that commit.
Which issue(s) this PR fixes: I did not see any issue created for this PR, I can create one if needed.
Special notes for your reviewer: I know that SingleStat panels are deprecated and that Stat panels now provide the same panel-link functionality (thanks for that!), but we have several dashboards and migration is taking time. This PR being included would allow us to keep updating Grafana without breaking dashboards.
A funny thing that I noticed while debugging this is that the link would work properly if there was no data for the panel. I couldn't see why that happened, but I found it weird.