Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Updated font to Inter, updates typography, a start of moving legacy & global styles from sass to emotion #32988

Merged
merged 18 commits into from
Apr 14, 2021

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented Apr 14, 2021

  • Update main font from Roboto to Inter
  • Update main mono space font to Roboto Mono
  • Update typography
  • Add Typography storybook for the native elements
  • Adds a Typography component that will be implemented later and be similar to https://material-ui.com/components/typography/
  • Adds a GlobalStyles component and a start/embryo of moving old sass global styles to emotion
  • Rename palette.getHoverColor to palette.emphasize

@torkelo torkelo requested review from a team, jackw, natellium and dprokop and removed request for a team April 14, 2021 12:48
@domasx2
Copy link
Contributor

domasx2 commented Apr 14, 2021

600 weight (bold) glyphs were missing for Roboto, which made bold text look smudged on some systems as browser interpolates to 600 from other weight. Maybe we could fix this and add 600 with Inter?

@torkelo
Copy link
Member Author

torkelo commented Apr 14, 2021

@domasx2 where do you use font-weight 600?

@domasx2
Copy link
Contributor

domasx2 commented Apr 14, 2021

@domasx2 where do you use font-weight 600?

theme.typography.weight.bold is set to 600, and various designs (eg, unified alerting) call for it to be used

https://github.com/grafana/grafana/blob/master/packages/grafana-ui/src/themes/default.ts#L56

@torkelo
Copy link
Member Author

torkelo commented Apr 14, 2021

theme.typography.weight.bold is set to 600, and various designs (eg, unified alerting) call for it to be used
https://github.com/grafana/grafana/blob/master/packages/grafana-ui/src/themes/default.ts#L56

Did not know that we should always use semibold, will map bold to 500

@torkelo torkelo requested review from a team and aocenas and removed request for a team April 14, 2021 15:35
@torkelo torkelo merged commit bcd0958 into master Apr 14, 2021
@torkelo torkelo deleted the inter-font branch April 14, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants