Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestData: support boolean and strings in CSV metric response #33099

Merged
merged 2 commits into from Apr 20, 2021
Merged

TestData: support boolean and strings in CSV metric response #33099

merged 2 commits into from Apr 20, 2021

Conversation

ryantxu
Copy link
Member

@ryantxu ryantxu commented Apr 18, 2021 •
edited

This makes it easier to return boolean and string values using the testdata CSV scenario.

image

@ryantxu ryantxu requested a review from a team as a code owner April 18, 2021 22:50
@ryantxu ryantxu requested review from a team, aknuds1, ying-jeanne, hugohaggmark and peterholmberg and removed request for a team April 18, 2021 22:50
@ryantxu ryantxu mentioned this pull request Apr 18, 2021
Closed
@ryantxu ryantxu enabled auto-merge (squash) April 19, 2021 22:42
@CLAassistant
Copy link

CLAassistant commented Apr 20, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@ryantxu ryantxu disabled auto-merge April 20, 2021 18:16
@ryantxu ryantxu merged commit 18bbbaf into master Apr 20, 2021
@ryantxu ryantxu deleted the better-boolean-support branch April 20, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknuds1 aknuds1 Awaiting requested review from aknuds1

@ying-jeanne ying-jeanne Awaiting requested review from ying-jeanne

Assignees
No one assigned
Labels
area/backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryantxu @CLAassistant @grafanabot