Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Add git command to Dockerfile.ubuntu file #33247

Merged
merged 4 commits into from Apr 22, 2021

Conversation

dsotirakis
Copy link
Contributor

@dsotirakis dsotirakis commented Apr 22, 2021

What this PR does / why we need it:

Adds git to Dockerfile.ubuntu, to resolve dependencies fetched from github.

Which issue(s) this PR fixes:

Fixes #33223

Special notes for your reviewer:

Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apk is not the package manager on Debian.

@dsotirakis
Copy link
Contributor Author

apk is not the package manager on Debian.

God 🤦

@dsotirakis dsotirakis requested a review from aknuds1 April 22, 2021 06:21
Dockerfile.ubuntu Outdated Show resolved Hide resolved
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
@dsotirakis dsotirakis enabled auto-merge (squash) April 22, 2021 06:47
@dsotirakis dsotirakis merged commit 6acb99a into master Apr 22, 2021
Grafana Backend (DO NOT USE!) automation moved this from In progress to Done Apr 22, 2021
@dsotirakis dsotirakis deleted the add-git-to-dockerfile-ubuntu branch April 22, 2021 07:11
grafanabot pushed a commit that referenced this pull request Apr 22, 2021
* Add git to Dockerfile.ubuntu

* Use apt-get

* Add quiet flag

* Update Dockerfile.ubuntu

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
(cherry picked from commit 6acb99a)
dsotirakis added a commit that referenced this pull request Apr 22, 2021
* Add git to Dockerfile.ubuntu

* Use apt-get

* Add quiet flag

* Update Dockerfile.ubuntu

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
(cherry picked from commit 6acb99a)

Co-authored-by: Dimitris Sotirakis <dimitrios.sotirakis@grafana.com>
@osg-grafana osg-grafana changed the title Bug: Add git to Dockerfile.ubuntu Bug: Add git command to Dockerfile.ubuntu Apr 28, 2021
@osg-grafana osg-grafana changed the title Bug: Add git command to Dockerfile.ubuntu Bug: Add git command to Dockerfile.ubuntu file Apr 28, 2021
mortenaa pushed a commit to mortenaa/grafana that referenced this pull request May 25, 2021
* Add git to Dockerfile.ubuntu

* Use apt-get

* Add quiet flag

* Update Dockerfile.ubuntu

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Docker build fails with missing git binary using the Dockerfile.ubuntu version
3 participants