New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variables: Removes experimental Tags feature #33361
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugohaggmark
added
area/dashboard/templating
breaking change
Relevant for changelog generation
labels
Apr 26, 2021
hugohaggmark
requested review from
a team and
peterholmberg
and removed request for
a team
April 26, 2021 05:59
hugohaggmark
requested review from
a team,
thisisobate and
mckn
and removed request for
peterholmberg,
a team and
thisisobate
April 26, 2021 05:59
hugohaggmark
requested review from
oddlittlebird,
achatterjee-grafana and
osg-grafana
and removed request for
a team
April 26, 2021 06:15
dprokop
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Now that I read the docs more carefully, it looks like we should only deprecate this feature for v8, but what does that mean? Should the feature be removed from the UI only? |
mortenaa
pushed a commit
to mortenaa/grafana
that referenced
this pull request
May 25, 2021
* Variables: Removes experimental Tags feature * Refactor: adds dashboard migration * Tests: fixes snapshots * Docs: removes docs for experimental feature * Refactor: dummy change * Docs: removes reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/dashboard/templating
area/frontend
breaking change
Relevant for changelog generation
type/docs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes the experimental Tags feature
Which issue(s) this PR fixes:
Fixes #
Release notice breaking change
Removes the experimental Tags feature for Variables.