Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables: Removes experimental Tags feature #33361

Merged
merged 7 commits into from Apr 27, 2021

Conversation

hugohaggmark
Copy link
Contributor

@hugohaggmark hugohaggmark commented Apr 26, 2021

What this PR does / why we need it:
Removes the experimental Tags feature

Which issue(s) this PR fixes:
Fixes #

Release notice breaking change

Removes the experimental Tags feature for Variables.

@hugohaggmark hugohaggmark added area/dashboard/templating breaking change Relevant for changelog generation labels Apr 26, 2021
@hugohaggmark hugohaggmark added this to the 8.0.0 milestone Apr 26, 2021
@hugohaggmark hugohaggmark self-assigned this Apr 26, 2021
@hugohaggmark hugohaggmark requested review from a team and peterholmberg and removed request for a team April 26, 2021 05:59
@hugohaggmark hugohaggmark added this to In Review in Frontend Platform Backlog via automation Apr 26, 2021
@hugohaggmark hugohaggmark requested review from a team, thisisobate and mckn and removed request for peterholmberg, a team and thisisobate April 26, 2021 05:59
@hugohaggmark hugohaggmark requested a review from a team as a code owner April 26, 2021 06:15
@hugohaggmark hugohaggmark requested review from oddlittlebird, achatterjee-grafana and osg-grafana and removed request for a team April 26, 2021 06:15
Frontend Platform Backlog automation moved this from In Review to Done Apr 26, 2021
@hugohaggmark hugohaggmark reopened this Apr 26, 2021
Frontend Platform Backlog automation moved this from Done to In progress Apr 26, 2021
Copy link
Member

@dprokop dprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@hugohaggmark
Copy link
Contributor Author

Now that I read the docs more carefully, it looks like we should only deprecate this feature for v8, but what does that mean? Should the feature be removed from the UI only?

@hugohaggmark hugohaggmark merged commit f73be97 into master Apr 27, 2021
Frontend Platform Backlog automation moved this from In progress to Done Apr 27, 2021
@hugohaggmark hugohaggmark deleted the hugoh/vars-remove-experimental-feature branch April 27, 2021 03:57
mortenaa pushed a commit to mortenaa/grafana that referenced this pull request May 25, 2021
* Variables: Removes experimental Tags feature

* Refactor: adds dashboard migration

* Tests: fixes snapshots

* Docs: removes docs for experimental feature

* Refactor: dummy change

* Docs: removes reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants