Explore: Refactor deduplication, hiding of logs and Logs component #33531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanahuckova
requested review from
torkelo and
jackw
and removed request for
a team
ivanahuckova
added this to Under review
in Observability (deprecated, use Observability Squad)
via automation
aocenas
approved these changes
Apr 29, 2021
Observability (deprecated, use Observability Squad)
automation
moved this from Under review
to Done
Apr 29, 2021
mortenaa
pushed a commit
to mortenaa/grafana
that referenced
this pull request
May 25, 2021
…rafana#33531) * Move fitlering and deduplication to comnponent to enable future caching * Clean up LogsMetaInfo * Update * Memoize component * Fix type errors * Clean uo * Add tests for filtering in combination with deduplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is part of adding Logs Navigation to Explore. We need to refactor deduplication and level hiding so they are done within
<LogsContainer />. That way, we can cache logResults and still enable all the same functionality (deduplication, hiding levels) as when received from regular query.I have also cleaned up and moved meta info to its own component.
There is no new functionality, just refactored code.
Previous related PRs:
#32978
#33069
#33259