-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: update panel alert tab #33850
Conversation
df34d04
to
a8a17ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! It's pretty seemless going from panel to alert rule creation, and the navigation back to the panel from the rule list is awesome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some super minor nitpicks
0dc3766
to
51a5327
Compare
(cherry picked from commit a26507e)
What this PR does / why we need it:
defaultValues
query param. Expects JSON with form valuesreturnTo
query param.TODO:
dasboard_url
andpanel_url
annotations, these are to be generated at runtime. Not quite sure how to link existing rules to panels though.. perhaps that's not neededpanel.alerts.mp4
Which issue(s) this PR fixes:
Fixes https://github.com/grafana/alerting-squad/issues/9
Fixes https://github.com/grafana/alerting-squad/issues/141
Fixes https://github.com/grafana/alerting-squad/issues/110
Special notes for your reviewer:
I went with an odd way to get the number of rules into panel alerting tab. Better ideas are welcome!
Does anything else need to be modified?