Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure: Expose Azure settings to external plugins #34484

Merged
merged 1 commit into from May 25, 2021
Merged

Azure: Expose Azure settings to external plugins #34484

merged 1 commit into from May 25, 2021

Conversation

sunker
Copy link
Contributor

@sunker sunker commented May 20, 2021

What this PR does / why we need it:

Expose the Azure settings that was added in this PR to external plugins using environment variables.

Which issue(s) this PR fixes:

Fixes #33801

@sunker sunker added type/feature-request datasource/Azure Azure Monitor Datasource add to changelog old backport v8.0.x Mark PR for automatic backport to v8.0.x labels May 20, 2021
@sunker sunker added this to the 8.0.0-beta3 milestone May 20, 2021
@sunker sunker requested review from wbrowne and marefr May 20, 2021 11:51
@sunker sunker requested a review from a team as a code owner May 20, 2021 11:51
@sunker
Copy link
Contributor Author

sunker commented May 20, 2021

FYI @kostrse

marefr
marefr approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kostrse
Copy link
Contributor

kostrse commented May 20, 2021 •
edited

Maybe prefix them with GF_ to make the names match to variable names which Grafana understands (GF_AZURE_CLOUD, GF_AZURE_MANAGED_IDENTITY_CLIENT_ID and GF_AZURE_MANAGED_IDENTITY_ENABLED)?

@sunker
Copy link
Contributor Author

sunker commented May 25, 2021

I don't know @kostrse - the GF_ prefix is used for grafana variables such as version and edition. These feel more Azure specific? I'll merge now, but feel free to open a new PR if you have strong opinions about this.

@sunker sunker merged commit 92ac2c4 into main May 25, 2021
@sunker sunker deleted the azure/expose-settings-to-external-plugins branch May 25, 2021 11:40
@grafanabot grafanabot mentioned this pull request May 25, 2021
Merged
grafanabot pushed a commit that referenced this pull request May 25, 2021
@sunker @grafanabot
expose azure settings as env variables (#34484)
a7f0ef4 
(cherry picked from commit 92ac2c4)
sunker added a commit that referenced this pull request May 25, 2021
@grafanabot @sunker
expose azure settings as env variables (#34484) (#34647)
b1177e2 
(cherry picked from commit 92ac2c4)

Co-authored-by: Erik Sundell <erik.sundell@grafana.com>
@hugohaggmark hugohaggmark changed the title Azure: Expose azure settings to external plugins Azure: Expose Azure settings to external plugins Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marefr marefr marefr approved these changes

@wbrowne wbrowne Awaiting requested review from wbrowne

Assignees
No one assigned
Labels
add to changelog area/backend datasource/Azure Azure Monitor Datasource old backport v8.0.x Mark PR for automatic backport to v8.0.x type/feature-request
Projects
None yet
Milestone
8.0.0-beta3
Development

Successfully merging this pull request may close these issues.

Azure settings to external datasource plugins
4 participants
@sunker @kostrse @marefr @grafanabot