New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AzureMonitor: Display variables in resource picker for Azure Monitor Logs #34648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! Just need to handle that case when there's no variables defined. Either remove the template variable group in that case, or handle error in NestedRows.onRowToggleCollapse
.../app/plugins/datasource/grafana-azure-monitor-datasource/components/ResourcePicker/index.tsx
Outdated
Show resolved
Hide resolved
...c/app/plugins/datasource/grafana-azure-monitor-datasource/components/ResourcePicker/utils.ts
Show resolved
Hide resolved
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-34648-to-v8.0.x origin/v8.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x b4ce068f0e6adbe353be30d4c374beef108078bc
# Push it to GitHub
git push --set-upstream origin backport-34648-to-v8.0.x
git switch main
# Remove the local backport branch
git branch -D backport-34648-to-v8.0.x Then, create a pull request where the |
* AzureMonitor: Display variables in Resource Picker * tests * hide template variable group when there's no template variables (cherry picked from commit b4ce068)
) * AzureMonitor: Display variables in Resource Picker * tests * hide template variable group when there's no template variables (cherry picked from commit b4ce068) Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
What this PR does / why we need it:
Lists template variables in the Azure Monitor Logs resource picker
Which issue(s) this PR fixes:
Fixes #34590