Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard: Fix issue with title or folder change has no effect after exiting settings view #34677

Merged
merged 2 commits into from May 27, 2021
Merged

Dashboard: Fix issue with title or folder change has no effect after exiting settings view #34677

merged 2 commits into from May 27, 2021

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented May 25, 2021

Fixes problem where updating title or folder had no effect when going back to dashboard

@torkelo torkelo requested review from a team, oscarkilhed, natellium and jackw and removed request for a team and natellium May 25, 2021 17:40
@torkelo torkelo changed the title Dashboard: Fixes issue with title or folder change has no effect after existing settings view Dashboard: Fixes issue with title or folder change has no effect after exiting settings view May 25, 2021
@torkelo torkelo added this to the 8.0.0-beta3 milestone May 25, 2021
@torkelo torkelo added old backport v8.0.x Mark PR for automatic backport to v8.0.x add to changelog labels May 25, 2021
@torkelo torkelo requested a review from hugohaggmark May 26, 2021 11:57
hugohaggmark
hugohaggmark approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@hugohaggmark hugohaggmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected! 🎉

jackw
jackw approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@torkelo torkelo merged commit 6394a60 into main May 27, 2021
@torkelo torkelo deleted the dashboard-settings-update-effect branch May 27, 2021 08:07
@grafanabot grafanabot mentioned this pull request May 27, 2021
Merged
grafanabot pushed a commit that referenced this pull request May 27, 2021
@torkelo @grafanabot
Dashboard: Fixes issue with title or folder change has no effect afte…
e45f57b 
…r exiting settings view (#34677)

* Dashboard: Fixes issue with title or folder change has no effect after existing settings view

* Updates snapshot

(cherry picked from commit 6394a60)
torkelo added a commit that referenced this pull request May 27, 2021
@grafanabot @torkelo
Dashboard: Fixes issue with title or folder change has no effect afte…
3acfa1b 
…r exiting settings view (#34677) (#34786)

* Dashboard: Fixes issue with title or folder change has no effect after existing settings view

* Updates snapshot

(cherry picked from commit 6394a60)

Co-authored-by: Torkel Ödegaard <torkel@grafana.org>
@hugohaggmark hugohaggmark changed the title Dashboard: Fixes issue with title or folder change has no effect after exiting settings view Dashboard: Fix issue with title or folder change has no effect after exiting settings view Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackw jackw jackw approved these changes

@hugohaggmark hugohaggmark hugohaggmark approved these changes

@oscarkilhed oscarkilhed Awaiting requested review from oscarkilhed

Assignees
No one assigned
Labels
add to changelog area/frontend old backport v8.0.x Mark PR for automatic backport to v8.0.x
Projects
None yet
Milestone
8.0.0-beta3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@torkelo @jackw @hugohaggmark @grafanabot