Transformations: Prevent FilterByValue transform from crashing panel edit #34747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
requested review from
axelavargas,
thisisobate and
leventebalogh
and removed request for
a team
torkelo
added
old backport v8.0.x
torkelo
approved these changes
May 26, 2021
jackw
added a commit
that referenced
this pull request
May 26, 2021
hugohaggmark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR defends against an
undefinedfieldbeing passed togetMatcherOptionswhich prevents panel edit from crashing. Adding @leventebalogh as a reviewer as he helped squash it in a quick pairing session this afternoon! ❤️ 🎉Which issue(s) this PR fixes:
Fixes #34626
Special notes for your reviewer: