PieChart: Support row data in pie charts #34755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
added this to In Review (max. internal 8, external 3)
in Frontend Platform Backlog
via automation
dprokop
requested review from
a team,
peterholmberg,
natellium,
oscarkilhed and
dprokop
and removed request for
a team,
peterholmberg and
natellium
|
Ok, added logic that makes color overrides added by the color picker work |
mckn
reviewed
May 27, 2021
| @@ -152,6 +152,13 @@ export const getFieldDisplayValues = (options: GetFieldDisplayValuesOptions): Fi | |||
| } | |||
| } | |||
|
|
|||
| // Palette color modes use series index (field index) which does not work for when displaing rows | |||
| // So updating seriesIndex here makes the palette color modes work in "All values" mode | |||
| field.state = { | |||
There was a problem hiding this comment.
Nit: would it be worth to change this to something like field.state = setIndexForPaletteColor(field.state) and move the code + comment into a small help function.
torkelo
added
old backport v8.0.x
Frontend Platform Backlog
automation
moved this from In Review (max. internal 8, external 3)
to Done
May 28, 2021
grafanabot
pushed a commit
that referenced
this pull request
May 28, 2021
* PieChart: Support row data in pie chart * Make color override work * removed thing * Minor refactoring (cherry picked from commit 658cc5d)
torkelo
added a commit
that referenced
this pull request
May 28, 2021
hugohaggmark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's very frustrating that the pie chart currently cannot visualize:
A few weeks ago we removed the "all values" option that is part of stat/gauge/bargauge. Because it does not work with palette based color schemes, setting manual color does not work
either as we can only color fields, not values.
One way would be to add a transform that pivots the data (Rows to fields). But that is a bit painful from a user / ease of use perspective. In this PR I tested a way to update seriesIndex to get unique auto colors. We could never support custom color selection with this mode.
With this PR
The thing that would be nice to add with this an auto mode that selects Calculate or All values based on the data using some heuristic.
Question is given that color picker will never work with the data in this form, should we skip this solution and explore a way for a panel add a transform? but how to make that easy to use? Or panel edit to suggest a transform?
Updated so that color picker created overrides does work. They will say "not found" in panel edit but this feels ok