Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PanelChrome: Fix issue with empty panel after adding a non data panel and coming back from panel edit #34765

Merged
merged 2 commits into from May 27, 2021
Merged

PanelChrome: Fix issue with empty panel after adding a non data panel and coming back from panel edit #34765

merged 2 commits into from May 27, 2021

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented May 26, 2021

Fixes issue with empty / blank panels after adding a new panel and switching to Text or Dashboard list panel, then go back to dashboard and the newly added panel is empty.

@torkelo torkelo requested review from a team, jackw and kaydelaney and removed request for a team May 26, 2021 16:46
jackw
jackw approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@torkelo torkelo added the old backport v8.0.x Mark PR for automatic backport to v8.0.x label May 27, 2021
@torkelo torkelo added this to the 8.0.0-beta3 milestone May 27, 2021
@torkelo torkelo merged commit ca79d08 into main May 27, 2021
@torkelo torkelo deleted the fix-empty-panel-after-add branch May 27, 2021 10:19
@grafanabot grafanabot mentioned this pull request May 27, 2021
Merged
grafanabot pushed a commit that referenced this pull request May 27, 2021
@torkelo @grafanabot
PanelChrome: Fix issue with empty panel after adding a non data panel…
4717aa4 
… and coming back from panel edit (#34765)

* PanelChrome: Fix issue with empty panel after adding a non data panel and coming back from panel edit

* Removed the console.log

(cherry picked from commit ca79d08)
torkelo added a commit that referenced this pull request May 27, 2021
@grafanabot @torkelo
PanelChrome: Fix issue with empty panel after adding a non data panel…
c0d87c9 
… and coming back from panel edit (#34765) (#34804)

* PanelChrome: Fix issue with empty panel after adding a non data panel and coming back from panel edit

* Removed the console.log

(cherry picked from commit ca79d08)

Co-authored-by: Torkel Ödegaard <torkel@grafana.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackw jackw jackw approved these changes

@kaydelaney kaydelaney Awaiting requested review from kaydelaney

Assignees
No one assigned
Labels
add to changelog area/frontend old backport v8.0.x Mark PR for automatic backport to v8.0.x
Projects
None yet
Milestone
8.0.0-beta3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@torkelo @jackw @grafanabot