AzureMonitor: Support querying subscriptions and resource groups in Azure Monitor Logs #34766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshhunt
added
datasource/Azure
joshhunt
requested review from
a team and
andresmgot
and removed request for
a team
andresmgot
approved these changes
May 27, 2021
...plugins/datasource/grafana-azure-monitor-datasource/components/ResourcePicker/NestedRows.tsx
Show resolved
Hide resolved
...c/app/plugins/datasource/grafana-azure-monitor-datasource/components/ResourcePicker/utils.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+90
to
+91
| resourcecontainers | ||
| | where type == "microsoft.resources/subscriptions" |
There was a problem hiding this comment.
It'd be nice if microsoft developed a js library for building queries :P
sunker
approved these changes
May 27, 2021
joshhunt
force-pushed
the
joshhunt/azure-select-logs-resource-groups
branch
from
53c51d5
to
b2e0aa4
Compare
joshhunt
force-pushed
the
joshhunt/azure-select-logs-resource-groups
branch
from
b2e0aa4
to
8e7b460
Compare
hugohaggmark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for Azure Monitor Logs queries that target Subscriptions and Resource Groups directly, rather than only a singular resource. This lets you, for example, graph all virtual machines in a resource group with a single query, which is pretty cool!
It turns out this was a lot easier than initially thought - the complication was just making sure the UI was still good when it didn't have a full resource URI
Which issue(s) this PR fixes:
Fixes #34482