Alerting: Clarify that Threema Gateway Alerts support only Basic IDs #34828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aknuds1
added
area/alerting/notifications
aknuds1
requested changes
May 27, 2021
|
Ah, thanks, I somehow missed that! |
Threema Gateway supports two types of IDs: Basic IDs (where the encryption is managed by the API server) and End-to-End IDs (where the keys are managed by the user). This plugin currently does not support End-to-End IDs (since it's much more complex to implement, because the encryption needs to happen locally). Add a few clarifications to the UI.
dbrgn
force-pushed
the
threema-gateway-basic
branch
from
cca076f
to
ea6110c
Compare
dbrgn
requested review from
a team,
oscarkilhed,
thisisobate and
aknuds1
and removed request for
a team
aknuds1
approved these changes
May 27, 2021
|
Just closing and re-opening this to get checks unstuck. |
|
Thanks for contributing to Grafana! |
grafanabot
pushed a commit
that referenced
this pull request
May 28, 2021
Threema Gateway supports two types of IDs: Basic IDs (where the encryption is managed by the API server) and End-to-End IDs (where the keys are managed by the user). This plugin currently does not support End-to-End IDs (since it's much more complex to implement, because the encryption needs to happen locally). Add a few clarifications to the UI. Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> (cherry picked from commit 83a83de)
aknuds1
pushed a commit
that referenced
this pull request
May 28, 2021
…34871) Threema Gateway supports two types of IDs: Basic IDs (where the encryption is managed by the API server) and End-to-End IDs (where the keys are managed by the user). This plugin currently does not support End-to-End IDs (since it's much more complex to implement, because the encryption needs to happen locally). Add a few clarifications to the UI. Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> (cherry picked from commit 83a83de) Co-authored-by: Danilo Bargen <mail@dbrgn.ch>
dprokop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Threema Gateway supports two types of IDs: Basic IDs (where the
encryption is managed by the API server) and End-to-End IDs (where the
keys are managed by the user).
This plugin currently does not support End-to-End IDs (since it's much
more complex to implement, because the encryption needs to happen
locally). Add a few clarifications to the UI.
(Note: There's also an "Info" key in the notifier plugin which contains more information, but I did not find out where in the UI this is being displayed 😕 Maybe it would be good to show this info text more prominently for alert plugins.)