Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Bump sanitize-url to 5.0.2 #35088

Merged
merged 1 commit into from Jun 3, 2021
Merged

Chore: Bump sanitize-url to 5.0.2 #35088

merged 1 commit into from Jun 3, 2021

Conversation

jackw
Copy link
Contributor

@jackw jackw commented Jun 2, 2021

What this PR does / why we need it:
Sanitize-url 5.0.1 doesn't remove zero-width characters from URLs. 5.0.2 was released yesterday to address this problem.

Bumped the types and removed the types devDependency in root package.json as library is a dependency of @grafana/data package.

Which issue(s) this PR fixes:

Fixes #34528

Special notes for your reviewer:

@jackw jackw added this to the 8.0.0 milestone Jun 2, 2021
@jackw jackw requested review from mckn and hugohaggmark June 2, 2021 09:51
@jackw jackw self-assigned this Jun 2, 2021
@jackw jackw requested a review from a team June 2, 2021 09:51
Copy link
Contributor

@hugohaggmark hugohaggmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! 🎉

Copy link
Contributor

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackw jackw added the old backport v8.0.x Mark PR for automatic backport to v8.0.x label Jun 3, 2021
@jackw jackw merged commit 9df23b8 into main Jun 3, 2021
@jackw jackw deleted the jackw/malformed-data-links branch June 3, 2021 08:05
grafanabot pushed a commit that referenced this pull request Jun 3, 2021
jackw added a commit that referenced this pull request Jun 3, 2021
(cherry picked from commit 9df23b8)

Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
aknuds1 pushed a commit that referenced this pull request Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malformed Data Link - version 8b1 and 8b2
3 participants