Alerting: Allow any "evaluate for" value >=0 in the alert rule form #35807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domasx2
requested review from
peterholmberg,
nathanrodman,
a team and
tskarhed
and removed request for
a team
|
|
Alerting frontend backlog
automation
moved this from Review in progress
to Reviewer approved
Jun 17, 2021
osg-grafana
changed the title
bryanuribe
pushed a commit
to open-o11y/grafana
that referenced
this pull request
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It updates "evaluate for" field validator in the rule form to allow any value >= 0. Previously it would allow min 10 seconds.
0-for.mp4
Which issue(s) this PR fixes:
Fixes #35756
Special notes for your reviewer: