Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loki: Send correct time range in template variable queries #36268

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Loki: Send correct time range in template variable queries #36268

merged 1 commit into from
Jun 29, 2021

Conversation

ivanahuckova
Copy link
Member

@ivanahuckova ivanahuckova commented Jun 29, 2021 •
edited
Loading

What this PR does / why we need it:

For template variable queries we've been using incorrect from and to parameters. These should have been everywhere (in all loki queries) start & end https://grafana.com/docs/loki/latest/api/#get-lokiapiv1labels. This PR fixes it.

@ivanahuckova ivanahuckova added this to the 8.0.4 milestone Jun 29, 2021
@ivanahuckova ivanahuckova self-assigned this Jun 29, 2021
@ivanahuckova ivanahuckova requested a review from a team June 29, 2021 12:42
@ivanahuckova ivanahuckova requested review from olbo98, gabor and Elfo404 and removed request for a team and olbo98 June 29, 2021 12:42
Elfo404
Elfo404 approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@Elfo404 Elfo404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from start to end!

@ivanahuckova ivanahuckova merged commit abb1c10 into main Jun 29, 2021
@ivanahuckova ivanahuckova deleted the ivana/loki-variables-params branch June 29, 2021 16:06
Observability (deprecated, use Observability Squad) automation moved this from Under review to Done Jun 29, 2021
@grafanabot grafanabot mentioned this pull request Jun 29, 2021
Merged
grafanabot pushed a commit that referenced this pull request Jun 29, 2021
@ivanahuckova @grafanabot
Update getTimeRangeParams to return start & end instead of from & to (#…
09db2d3 
…36268)

(cherry picked from commit abb1c10)
ivanahuckova added a commit that referenced this pull request Jun 29, 2021
@grafanabot @ivanahuckova
Update getTimeRangeParams to return start & end instead of from & to (#…
d478184 
…36268) (#36275)

(cherry picked from commit abb1c10)

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
bryanuribe pushed a commit to open-o11y/grafana that referenced this pull request Aug 6, 2021
@ivanahuckova @bryanuribe
Update getTimeRangeParams to return start & end instead of from & to (g…
5db47d4 
…rafana#36268)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elfo404 Elfo404 Elfo404 approved these changes

@gabor gabor Awaiting requested review from gabor

Assignees

@ivanahuckova ivanahuckova

Labels
add to changelog area/frontend datasource/Loki old backport v8.0.x Mark PR for automatic backport to v8.0.x type/bug
Projects
Observability (deprecated, use Observ...
  
Done
Milestone
8.0.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivanahuckova @Elfo404 @grafanabot