Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add export to csv in table panel #3803

Merged
merged 1 commit into from
Jan 21, 2016
Merged

Conversation

xadhoom
Copy link
Contributor

@xadhoom xadhoom commented Jan 20, 2016

This little addition allows to export the table panel to csv, whatever table is displayed.

@CLAassistant
Copy link

CLA assistant check
All committers have accepted the CLA.

@xadhoom xadhoom force-pushed the table_export_csv branch 2 times, most recently from df784ef to 345f4d4 Compare January 20, 2016 16:00
@bergquist bergquist self-assigned this Jan 21, 2016
@bergquist
Copy link
Contributor

Great!

But since the export code for seriesToCsv is in kbn.js I think this should be solved in kbn as well.
Perhaps even move both of them into a export.js file. But its not a requirement.

As long as they are both in the same place I will accept this PR.

@xadhoom
Copy link
Contributor Author

xadhoom commented Jan 21, 2016

well, there's a reasoning behind that.
The export seriesToCsv in kbn.js is time series related, which is not suitable at all for tables.
This kind of export is very table specific, that's why I've placed it into the table controller.

If is ok to add a specific export function in kbn.js only for tables, I'll add it and update the pull request.

@bergquist
Copy link
Contributor

A new method would be ok.
Something like exportTableDataToCsv .

@xadhoom
Copy link
Contributor Author

xadhoom commented Jan 21, 2016

PR updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/changes-needed pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants