LibraryPanels: Improves export and import of library panels between orgs #39214
Conversation
hugohaggmark
requested review from
a team,
sdboyer,
malcolmholmes,
ashharrison90 and
kaydelaney
and removed request for
a team
public/app/features/manage-dashboards/components/ImportDashboardForm.tsx
Outdated
Show resolved
Hide resolved
public/app/features/manage-dashboards/components/ImportDashboardForm.tsx
Outdated
Show resolved
Hide resolved
hugohaggmark
requested review from
osg-grafana
and removed request for
a team
public/app/features/manage-dashboards/components/ImportDashboardForm.tsx
Outdated
Show resolved
Hide resolved
public/app/features/manage-dashboards/components/ImportDashboardForm.tsx
Outdated
Show resolved
Hide resolved
|
@achatterjee-grafana thank you it looks great! |
…rdForm.tsx Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
…rdForm.tsx Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
…afana/grafana into hugoh/libpanels-export-import
There was a problem hiding this comment.
Great job @hugohaggmark 🚀, I tested locally the PR, and review the frontend code, everything works as expected 👏🏾.
|
Thank you @axelavargas! |
|
Great job 🚀, the functionality looks great, i just left one comment regarding the simplejson package, we want to avoid it because of the performances etc. |
There was a problem hiding this comment.
LGTM @sdboyer since we make the close validation of panel now, we can add panel library fields also in the schema.
|
@hugohaggmark which grafana version are u using here? is it 8.0? I am not able to find this feature in 8.0 version |
@deeruattavar Looking at the milestone tells me this should probably be in 8.3.0-beta1. Let me know if that helps. |
What this PR does / why we need it:
This PR makes improvements to the user experience when exporting and importing dashboards containing library panels from Grafana. Keeping it super simple for this first iteration. Only panels that don't exist in the org/instance where the dashboard is imported to will be imported. We will keep all existing library panels unchanged.
Which issue(s) this PR fixes:
Fixes #36897
Special notes for your reviewer: