Add elasticsearch as annotations source #403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! will try to find time to check this out |
|
Hi @torkelo , do you need some modification about this change ? |
|
No, just time to try it out. Maybe in the next couple of days. |
|
Please sign the contributor license agreement http://grafana.org/docs/contributing/cla.html |
|
Any further progress on this? Sounds like a great addition. |
|
I am stuck in discussions about the CLA with my company. We've signed CLA before, but the patent related part seems out of question. I'll try to make some progress today |
|
rebased against master |
Experimental support for elasticsearch as annotation source.
Current feature:
- allow to search against any index ("toto", "_all", "toto,titi")
- allow any query
Limitations:
- static fields used for timestamp and annotation message
- size of request is hard-coded
- direct use of $http instead of elasticsearch ejs client
- no tests
Fix grafana#201
torkelo
added a commit
that referenced
this pull request
Jul 13, 2014
|
@kamaradclimber the patent license is only in regards to code you actually contribute AFAIK, is that a problem if you are willingly submitting the code? I'm just interested in why your company has taken issue with it. |
|
How well should this work with events stored in elasticsearch via anthracite? |
|
CLA signed (finally!) |
|
Great. |
- allow to configure timestamp field - allow to configure message field - allow to configure fetched events
|
@sciurus I have pushed a few addition to make fields used for research configurable. Can you tell me if it is sufficient? |
Dieterbe
pushed a commit
to Dieterbe/grafana
that referenced
this pull request
Aug 11, 2015
Rabbitmq 400
IevaVasiljeva
pushed a commit
that referenced
this pull request
Jul 14, 2022
* Fix: Choose Lookup params per auth module Co-authored-by: Karl Persson <kalle.persson@grafana.com> Fix: Prefer pointer to struct in lookup Co-authored-by: Karl Persson <kalle.persson@grafana.com> Fix: user email for ldap Co-authored-by: Karl Persson <kalle.persson@grafana.com> Fix: Use only login for lookup in LDAP Co-authored-by: Karl Persson <kalle.persson@grafana.com> Fix: use user email for ldap Co-authored-by: Karl Persson <kalle.persson@grafana.com> fix remaining test fix nit picks (cherry picked from commit 09ca54d4665583b5648fea5726a19e0b58df4ec0) * fix integration tests (cherry picked from commit 16c3077bb39f41acacbef4b13c65c7c907c54de7) * Release: Bump version to 8.3.9 (#403) * Change bump-version.yml * "Release: Updated versions in package to 8.3.9" Co-authored-by: dsotirakis <dimitrios.sotirakis@grafana.com> * Update yarn.lock Co-authored-by: jguer <joao.guerreiro@grafana.com> Co-authored-by: Grot (@grafanabot) <43478413+grafanabot@users.noreply.github.com>
kminehart
added a commit
that referenced
this pull request
Jul 15, 2022
* Fix XSS in runbook URL (#383) * "Release: Updated versions in package to 8.3.8" (#385) * Fix: Choose Lookup params per auth module v8.3.x (#401) * Fix: Choose Lookup params per auth module Co-authored-by: Karl Persson <kalle.persson@grafana.com> Fix: Prefer pointer to struct in lookup Co-authored-by: Karl Persson <kalle.persson@grafana.com> Fix: user email for ldap Co-authored-by: Karl Persson <kalle.persson@grafana.com> Fix: Use only login for lookup in LDAP Co-authored-by: Karl Persson <kalle.persson@grafana.com> Fix: use user email for ldap Co-authored-by: Karl Persson <kalle.persson@grafana.com> fix remaining test fix nit picks * update lock * fix integration tests * [v8.3.x] Merge 'release-8.3.9` branch (#404) * Fix: Choose Lookup params per auth module Co-authored-by: Karl Persson <kalle.persson@grafana.com> Fix: Prefer pointer to struct in lookup Co-authored-by: Karl Persson <kalle.persson@grafana.com> Fix: user email for ldap Co-authored-by: Karl Persson <kalle.persson@grafana.com> Fix: Use only login for lookup in LDAP Co-authored-by: Karl Persson <kalle.persson@grafana.com> Fix: use user email for ldap Co-authored-by: Karl Persson <kalle.persson@grafana.com> fix remaining test fix nit picks (cherry picked from commit 09ca54d4665583b5648fea5726a19e0b58df4ec0) * fix integration tests (cherry picked from commit 16c3077bb39f41acacbef4b13c65c7c907c54de7) * Release: Bump version to 8.3.9 (#403) * Change bump-version.yml * "Release: Updated versions in package to 8.3.9" Co-authored-by: dsotirakis <dimitrios.sotirakis@grafana.com> * Update yarn.lock Co-authored-by: jguer <joao.guerreiro@grafana.com> Co-authored-by: Grot (@grafanabot) <43478413+grafanabot@users.noreply.github.com> * "Release: Updated versions in package to 8.3.10" (#409) * Update grabpl * update grabpl * CI: Update `grabpl` version - remove `--no-pull-enterprise` flag (#47013) * Update grabpl version * Sign drone * Remove --no-pull-enterprise flag * Sign drone * Update grabpl * update drone, cherry-pick some ci updates * update PR pipeline Co-authored-by: George Robinson <george.robinson@grafana.com> Co-authored-by: Grot (@grafanabot) <43478413+grafanabot@users.noreply.github.com> Co-authored-by: Jguer <joao.guerreiro@grafana.com> Co-authored-by: Dimitris Sotirakis <dimitrios.sotirakis@grafana.com> Co-authored-by: Kevin Minehart <kmineh0151@gmail.com> Co-authored-by: Dimitris Sotirakis <sotirakis.dim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for elasticsearch as annotation source.
Current feature:
Limitation: cannot use the classic "logstash" index name pattern since the index is fixed.
I probably won't fix it in this PR since people can use aliases in the beginning
Fix #201