Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Fix dashboard quota limit for imports #41495

Merged
merged 6 commits into from
Nov 16, 2021
Merged

API: Fix dashboard quota limit for imports #41495

merged 6 commits into from
Nov 16, 2021

Conversation

yangkb09
Copy link
Contributor

@yangkb09 yangkb09 commented Nov 9, 2021

What this PR does / why we need it:
Fix import endpoint for respecting quota

Which issue(s) this PR fixes:

Fixes #34343

Special notes for your reviewer:

pkg/tests/api/dashboards/api_dashboards_test.go Outdated Show resolved Hide resolved
pkg/tests/api/dashboards/api_dashboards_test.go Outdated Show resolved Hide resolved
pkg/tests/testinfra/testinfra.go Outdated Show resolved Hide resolved
pkg/tests/testinfra/testinfra.go Outdated Show resolved Hide resolved
@yangkb09 yangkb09 marked this pull request as ready for review November 15, 2021 15:25
@yangkb09 yangkb09 requested a review from a team as a code owner November 15, 2021 15:25
@yangkb09 yangkb09 requested review from sdboyer and dsotirakis and removed request for a team November 15, 2021 15:25
@yangkb09 yangkb09 added this to the 8.3.0 milestone Nov 15, 2021
@yangkb09 yangkb09 enabled auto-merge (squash) November 15, 2021 17:11
Copy link
Contributor

@papagian papagian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@yangkb09 yangkb09 merged commit f49e08c into main Nov 16, 2021
@yangkb09 yangkb09 deleted the kat/dashboard-quota branch November 16, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard Quota Limit doesn't work on imports
3 participants