Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel edit: Overrides now highlight correctly when searching #41684

Merged
merged 1 commit into from Nov 16, 2021

Conversation

ashharrison90
Copy link
Contributor

What this PR does / why we need it:

  • passes searchQuery to the overrides section and adds Highlighter to highlight correctly:
  • before: image
  • after: image

Which issue(s) this PR fixes:

Fixes #34638

Special notes for your reviewer:

@ashharrison90 ashharrison90 added this to the 8.3.0 milestone Nov 15, 2021
@ashharrison90 ashharrison90 requested a review from a team November 15, 2021 12:53
@ashharrison90 ashharrison90 self-assigned this Nov 15, 2021
@ashharrison90 ashharrison90 added this to In Review (max internal 8, max external 3) in User essentials squad (deprecated) via automation Nov 15, 2021
@ashharrison90 ashharrison90 requested review from joshhunt and thisisobate and removed request for a team November 15, 2021 12:54
@ashharrison90 ashharrison90 removed this from In Review (max internal 8, max external 3) in User essentials squad (deprecated) Nov 15, 2021
@ashharrison90 ashharrison90 merged commit 0e76f34 into main Nov 16, 2021
@ashharrison90 ashharrison90 deleted the ash/34638 branch November 16, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panel edit: override search result label is not highlghted
2 participants