Hotkeys: Make time range absolute/permanent #43802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typing `t a` in Explore or Dashboards will turn a relative time like "Last 1 hour" into an absolute range to make the URL permanent, so that when sharing it others will see the same data. - registered `t a` in key service - new `AbsoluteTimeEvent` dispatch via global event bus - dashboard times handled in TimeSrv - Explore times handled in Explore.tsx and Explore's time reducer I could not find an easy way to combine time handling for Exlore and Dashboard in one place.
davkal
requested review from
a team and
connorlindsey
and removed request for
a team
connorlindsey
approved these changes
Jan 7, 2022
davkal
changed the title
|
This is awesome (when I finally found this issue), but I was expecting a button somewhere in the GUI to do this, and spent ages clicking around looking for it. Also the documentation for using dashboards doesn't mention the When you hover over a relative time range, it shows the absolute time range. Perhaps there could be a button inside here to grab this range and apply it?
Apart from that, it makes me wonder how much other functionality in Grafana is hidden in the GUI but available with magic key sequences :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typing
t ain Explore or Dashboards will turn a relative time like "Last 1 hour"into an absolute range to make the URL permanent, so that when sharing it others
will see the same data.
t ain key serviceAbsoluteTimeEventdispatch via global event bust ato help screenI could not find an easy way to combine time handling for Exlore and Dashboard in one place.
Fixes #37893
Supersedes #37899
CC @owen-d