InfluxDB: variables migration to backend #45512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
joey-grafana
changed the title
yesoreyeram
reviewed
Feb 18, 2022
yesoreyeram
reviewed
Feb 24, 2022
yesoreyeram
approved these changes
Feb 24, 2022
There was a problem hiding this comment.
I am ok to approve. But prefer to use @gabor's expertise as well.
alexweav
pushed a commit
that referenced
this pull request
Mar 3, 2022
* Remove check for explore * Remove core app import * applyVariables for select * applyVariables for tags * applyVariables for other query props * applyTemplateVariables for flux * applyTemplateVariables for influx * Backwards compatibility * interpolateVariablesInQueries * Update InfluxQL mode and alias in test * Should interpolate all variables with Flux mode * Variables should be interpolated correctly * Removed unused import * explore in if check * Removing backwards compat copy from classicQuery * Return expandedQuery * Const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Part of #43076
This PR contains the changes needed to applyTemplateVariables() to InfluxQL queries (which are run through the backend).
Test scenarios:
api/ds/querygdev-influxdb-influxqlPS: make sure
[feature_toggles]
enable = influxdbBackendMigration