Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger: Use specified format for file logger #46970

Merged
merged 2 commits into from Mar 26, 2022
Merged

Logger: Use specified format for file logger #46970

merged 2 commits into from Mar 26, 2022

Conversation

sakjur
Copy link
Contributor

@sakjur sakjur commented Mar 25, 2022

Fixes #45941

@sakjur sakjur added the backport v8.4.x Mark PR for automatic backport to v8.4.x label Mar 25, 2022
@sakjur sakjur added this to the 8.4.5 milestone Mar 25, 2022
@sakjur sakjur requested a review from a team as a code owner March 25, 2022 16:36
@sakjur sakjur requested review from papagian and removed request for a team March 25, 2022 16:36
ying-jeanne
ying-jeanne approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@ying-jeanne ying-jeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speedy gonzales, LGTM

@ying-jeanne ying-jeanne enabled auto-merge (squash) March 25, 2022 17:14
@ying-jeanne ying-jeanne merged commit 7bc821b into main Mar 26, 2022
@ying-jeanne ying-jeanne deleted the emil/log/fix-non-logfmt-formats branch March 26, 2022 10:40
@grafanabot grafanabot mentioned this pull request Mar 26, 2022
Merged
grafanabot pushed a commit that referenced this pull request Mar 26, 2022
@sakjur @grafanabot
Logger: Use specified format for file logger (#46970)
cce0bf0 
Fixes #45941

(cherry picked from commit 7bc821b)
ying-jeanne pushed a commit that referenced this pull request Mar 29, 2022
@grafanabot @sakjur
Logger: Use specified format for file logger (#46970) (#46979)
2f33b12 
Fixes #45941

(cherry picked from commit 7bc821b)

Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>
This was referenced Mar 29, 2022
Closed
Closed
@nicolaerosia
Copy link

nicolaerosia commented Mar 31, 2022 •
edited

The format was changed, these field uname and userId are missing, can you please check #46996 ?

@nicolaerosia nicolaerosia mentioned this pull request Apr 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ying-jeanne ying-jeanne ying-jeanne approved these changes

@kylebrandt kylebrandt Awaiting requested review from kylebrandt

@papagian papagian Awaiting requested review from papagian papagian was automatically assigned from grafana/backend-platform

Assignees
No one assigned
Labels
add to changelog area/backend backport v8.4.x Mark PR for automatic backport to v8.4.x type/bug
Projects
None yet
Milestone
8.4.5
Development

Successfully merging this pull request may close these issues.

custom.ini log.file format to json setting not working
5 participants
@sakjur @nicolaerosia @ying-jeanne @marefr @grafanabot