RolePicker: Fix submenu position on horizontal space overflow #50769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarity-89
requested review from
Jguer and
IevaVasiljeva
and removed request for
a team
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/22435 |
alexanderzobnin
approved these changes
Jun 14, 2022
grafanabot
pushed a commit
that referenced
this pull request
Jun 15, 2022
(cherry picked from commit 2fbe99c)
Clarity-89
added a commit
that referenced
this pull request
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix role picker's submenu to be shown on the left side of the menu, when there's not enough horizontal space to show it on the right.
Which issue(s) this PR fixes:
Fixes https://github.com/grafana/grafana-enterprise/issues/3462
Special notes for your reviewer:
Before:
After:
